Conversation
| f"Input time is not during Sector {self.sector} observations." | ||
| ) | ||
| ffi_name = self.ffi_names[np.where((t > start))[0][-1]] | ||
| ffi_name = self.ffi_names[np.where((time > start))[0][-1]] |
There was a problem hiding this comment.
This might be separate from this PR, as I think this line is reproducing the previous behavior - but are we sure that this is what we want?
This looks to me like we're grabbing the first FFI name that's in the cube that has a time after the requested time. But I think the FFI times are midpoints, so in some cases we might return the wrong exposure. We might want to find the ffi-midpoint time that's closest to our time instead.
Contributor
Author
There was a problem hiding this comment.
Yeah, this reproduces existing behavior. That is something we could do if you prefer. But that would be a separate issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates how comments are stored in fits.py (#21) and fixes the time bug in get_ffi (#19)